web: show 'alerts on top' toggle even when there are no tests #4182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Clubhouse Story #11050: "Alerts on Top" toggle visible even when no tests are present. |
maiamcc
approved these changes
Feb 9, 2021
There was a problem hiding this comment.
I'm not sure if it's poor form to simply set
visibility: hiddenrather than omit the checkboxes entirely
haaa that is 100% a question for @hyu, but the code logic looks fine and i'd feel good about merging this and letting Han go back over the styling after if needful, cuz imho it looks good enough(tm).
landism
deleted the
mlandis/ch11050/alerts-on-top-toggle-visible-even-when-no
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if it's poor form to simply set
visibility: hiddenrather than omit the checkboxes entirely - it's certainly vastly easier than changing a bunch of css to keep the 'alerts on top' toggle in place when the filter checkboxes are absent.