New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor: pull in tilt-apiserver #4189

Merged

nicks merged 1 commit into master from nicks/apiserver

Feb 10, 2021

Member

nicks commented Feb 10, 2021

Hello @nicks,

Please review the following commits I made in branch nicks/apiserver:

2c755c3 (2021-02-10 17:24:11 -0500)
vendor: pull in tilt-apiserver

Code review reminders, by giving a LGTM you attest that:

Commits are adequately tested
Code is easy to understand and conforms to style guides
Incomplete code is marked with TODOs
Code is suitably instrumented with logging and metrics

Member Author

nicks commented Feb 10, 2021

This doesn't integrate anything yet, it just vendors the code i want to demo


          vendor: pull in tilt-apiserver

nicks force-pushed the nicks/apiserver branch from 2c755c3 to 4006969 Compare

February 10, 2021 22:26

nicks merged commit b6520fc into master

nicks deleted the nicks/apiserver branch

February 10, 2021 22:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment