Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: Fix Sidebar item layout bugs #4191

Merged
merged 5 commits into from
Feb 12, 2021
Merged

web: Fix Sidebar item layout bugs #4191

merged 5 commits into from
Feb 12, 2021

Conversation

hyu
Copy link
Member

@hyu hyu commented Feb 11, 2021

Long resource names no longer break the layout!

Before After
Screen Shot 2021-02-04 at 5 52 12 PM Screen Shot 2021-02-11 at 6 43 50 PM

 
Also, the pin position looks more intentional:

Before After
Screen Shot 2021-02-11 at 6 47 48 PM Screen Shot 2021-02-11 at 6 48 06 PM

@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #11156: sidebar item view layout is busted.

@hyu hyu requested a review from maiamcc February 11, 2021 23:49
@maiamcc
Copy link
Contributor

maiamcc commented Feb 12, 2021

Will look in a bit. To confirm @hyu , does the right margin look reasonable when the Auto toggle is there, too?

@hyu
Copy link
Member Author

hyu commented Feb 12, 2021

@maiamcc — Yes, it works when the AUTO button is there too!

Screen Shot 2021-02-12 at 12 35 13 PM

@hyu hyu merged commit e6adc3b into master Feb 12, 2021
@hyu hyu deleted the hyu/ch11156/sidebar-item branch February 12, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants