cli: add a helper for querying the tilt server #4218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Clubhouse Story #11415: add a helper for querying tilt apiserver. |
nicks
commented
Feb 18, 2021
| @@ -52,8 +52,10 @@ func (c *tiltfileResultCmd) name() model.TiltSubcommand { return "tiltfile-resul | |||
| func (c *tiltfileResultCmd) register() *cobra.Command { | |||
| cmd := &cobra.Command{ | |||
| Use: "tiltfile-result", | |||
| Short: "Exec the Tiltfile and print data about execution. By default, prints Tiltfile execution results as JSON (note: the API is unstable and may change); can also print timings of Tiltfile Builtin calls.", | |||
| Long: `Exec the Tiltfile and print data about execution. By default, prints Tiltfile execution results as JSON (note: the API is unstable and may change); can also print timings of Tiltfile Builtin calls. | |||
| Short: "Exec the Tiltfile and print data about execution", | |||
There was a problem hiding this comment.
shortened this up a bit to improve the tilt alpha --help output
|
Is there a design doc somewhere I could read about what you're implementing before I try to do code reviews on it? |
|
yep, here it is! https://app.clubhouse.io/windmill/story/11415/add-a-helper-for-querying-tilt-apiserver tho this particular command is more of a debugging command for ourselves while we're developing it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @maiamcc, @milas,
Please review the following commits I made in branch nicks/ch11415:
51fba76 (2021-02-18 11:57:17 -0500)
cli: add a helper for querying the tilt server
Code review reminders, by giving a LGTM you attest that: