Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web: remove facets. Fixes https://github.com/tilt-dev/tilt/issues/4219 #4225

Merged
merged 1 commit into from Feb 19, 2021
Merged

web: remove facets. Fixes https://github.com/tilt-dev/tilt/issues/4219 #4225

merged 1 commit into from Feb 19, 2021

Conversation

nicks
Copy link
Member

@nicks nicks commented Feb 18, 2021

Hello @hyu, @landism,

Please review the following commits I made in branch nicks/ch11427:

46fca22 (2021-02-18 17:24:19 -0500)
web: remove facets. Fixes #4219

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested review from hyu and landism February 18, 2021 22:24
@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #11427: large facets make tilt slow.

@nicks nicks force-pushed the nicks/ch11427 branch 2 times, most recently from 93877f5 to 6145ac8 Compare February 18, 2021 23:44
hyu
hyu approved these changes Feb 19, 2021
View reviewed changes
Copy link
Member

@hyu hyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goodbye facets, we hardly knew ya. (But really, I appreciate the shoutout to Tilt issue #4148, wherein some version of facets might come back soon.)

@nicks nicks merged commit bb40f0c into master Feb 19, 2021
@nicks nicks deleted the nicks/ch11427 branch February 19, 2021 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyu hyu hyu approved these changes

@landism landism Awaiting requested review from landism

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

large facets make tilt slow
2 participants
@nicks @hyu