Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: make DI practical for controllers #4250

Merged
merged 4 commits into from
Feb 26, 2021

Commits on Feb 25, 2021

  1. server: make DI practical for controllers

    This is a bit roundabout, but the key issue is that controllers
    (`Reconciler`s) need the controller client to do their work, which
    comes from the `ctrl.Manager`, but isn't available until the manager
    is actually connected to the API server, so it's not suitable for
    normal DI.
    
    A `ControllerBuilder` provides the glue between the manager and
    reconcilers by providing them with the client and calling the
    `SetupWithManager` methods on them. The latter of these is a standard
    method that's bootstrapped by the codegen (but not part of the
    `Reconciler` interface).
    milas committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    b3218f8 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2021

  1. Configuration menu
    Copy the full SHA
    b420b9c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ac10512 View commit details
    Browse the repository at this point in the history
  3. store: remove subscribers in reverse order

    This prevents the HUD server blocking forever since the controller manager is still connected.
    milas committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    855ad35 View commit details
    Browse the repository at this point in the history