filewatch: perform double writes to store + apiserver #4307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicks
approved these changes
Mar 12, 2021
milas
force-pushed
the
milas/filewatch-double-write
branch
2 times, most recently
from
9ee7350
to
e020df5
Compare
There's a variety of changes here to actually ensure that the created FileWatch objects are actually acceptable by apiserver. With these changes, the file watches are now visible in the API server!
milas
force-pushed
the
milas/filewatch-double-write
branch
from
e020df5
to
eb2f64e
Compare
For now, simply hold onto a reference to the object to update rather than fetching from apiserver. This hopefully prevents race issues until everything is fully in apiserver.
|
@nicks Mind taking a quick pass at this again? It should be mostly the same with one exception other than bringing up-to-date with The exception is ec5ff3e - I changed to hold onto a reference of the object to use for updates vs fetching from apiserver; I've been seeing suspicious elevated rates of integration tests failures that were making me nervous, so this seemed safer until it's fully in apiserver. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a variety of changes here to actually ensure that the
created FileWatch objects are actually acceptable by apiserver
(e.g.
:isn't a valid character in labels, so I split it intotarget type + target name labels instead of playing string split
games).
With these changes, the file watches are now visible in the API
server.
✅
Need to merge + bump dep for tilt-dev/tilt-apiserver#26 before merge