filewatch: apply global ignores to config file watches #4310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a regression in v0.18.12 - the global ignores were no longer getting applied to the `configs:singleton` target for the config files and/or anything explicitly watched with `watch_file`. Closes #4308.
milas
force-pushed
the
milas/bugfix-watch-ignores
branch
from
91139d6
to
e1add8f
Compare
milas
added a commit
that referenced
this pull request
Mar 12, 2021
This was a regression in v0.18.12 - the global ignores were no longer getting applied to the `configs:singleton` target for the config files and/or anything explicitly watched with `watch_file`. This is a cherry-pick of 969b62d.
pull bot
pushed a commit
to rizalgowandy/tilt
that referenced
this pull request
Mar 12, 2021
This was a regression in v0.18.12 - the global ignores were no longer getting applied to the `configs:singleton` target for the config files and/or anything explicitly watched with `watch_file`. Closes tilt-dev#4308.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a regression in v0.18.12 - the global ignores were no
longer getting applied to the
configs:singletontarget for theconfig files and/or anything explicitly watched with
watch_file.Closes #4308.