Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apis: simplify core.tilt.dev to tilt.dev #4334

Merged
merged 1 commit into from
Mar 18, 2021
Merged

apis: simplify core.tilt.dev to tilt.dev #4334

merged 1 commit into from
Mar 18, 2021

Conversation

nicks
Copy link
Member

@nicks nicks commented Mar 17, 2021

Hello @milas,

Please review the following commits I made in branch nicks/core:

ea17be0 (2021-03-17 16:08:45 -0400)
apis: simplify core.tilt.dev to tilt.dev

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks
Copy link
Member Author

nicks commented Mar 17, 2021

the "core" prefix seemed kind of random and unnecessary, though i think it's useful to have "tilt.dev" in the group name

@nicks nicks merged commit cacb1ec into master Mar 18, 2021
@nicks nicks deleted the nicks/core branch March 18, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants