tests: add explicit dump engine call to an integration test #4342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicks
approved these changes
Mar 18, 2021
Currently, the integration tests (try to) invoke an engine dump on failure to give state for debugging purposes. We had a regression recently, however, where the engine dump command was completely non-functional due to a serialization issue. This adds an explicit call to dump the engine in one of the tests which will catch any total breakage like this. It's not a comprehensive test of the actual output of the engine dump (though the CLI command ensures it's valid JSON), but that's okay because the API of it is not stable and we're moving away from it towards a stable interface for this type of introspection via apiserver.
milas
force-pushed
the
milas/int-test-dump-engine
branch
from
2800f8c
to
b6903f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the integration tests (try to) invoke an engine dump
on failure to give state for debugging purposes.
We had a regression recently (#4318), however, where the engine dump
command was completely non-functional due to a serialization
issue. This adds an explicit call to dump the engine in one of
the tests which will catch any total breakage like this. It's
not a comprehensive test of the actual output of the engine
dump (though the CLI command ensures it's valid JSON), but
that's okay because the API of it is not stable and we're
moving away from it towards a stable interface for this type
of introspection via apiserver.