Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: hello-world with the new apiserver #4345

Merged
merged 1 commit into from
Mar 19, 2021
Merged

examples: hello-world with the new apiserver #4345

merged 1 commit into from
Mar 19, 2021

Conversation

nicks
Copy link
Member

@nicks nicks commented Mar 19, 2021

Hello @milas,

Please review the following commits I made in branch nicks/ch11574:

3aae74e (2021-03-19 12:21:39 -0400)
examples: hello-world with the new apiserver

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested a review from milas March 19, 2021 16:21
@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #11574: demo tilt alpha command for running cmd+filewatch.

@nicks nicks merged commit ffc4d9a into master Mar 19, 2021
@nicks nicks deleted the nicks/ch11574 branch March 19, 2021 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants