Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local: kill servers when their manifest is removed #4355

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Conversation

nicks
Copy link
Member

@nicks nicks commented Mar 22, 2021

Hello @milas, @landism,

Please review the following commits I made in branch nicks/orphans:

2f49289 (2021-03-22 16:22:21 -0400)
local: kill servers when their manifest is removed

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested review from landism and milas March 22, 2021 20:22
@nicks
Copy link
Member Author

nicks commented Mar 22, 2021

(i think this broke when i was converting things over to the new system)

Copy link
Contributor

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terrifying test name, but changes look good 👍

@nicks nicks merged commit f5bca33 into master Mar 22, 2021
@nicks nicks deleted the nicks/orphans branch March 22, 2021 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants