Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store: simplify the summary api a bit #4359

Merged
merged 1 commit into from
Mar 24, 2021
Merged

store: simplify the summary api a bit #4359

merged 1 commit into from
Mar 24, 2021

Conversation

nicks
Copy link
Member

@nicks nicks commented Mar 23, 2021

Hello @milas, @maiamcc,

Please review the following commits I made in branch nicks/summary:

a5863f7 (2021-03-23 16:02:21 -0400)
store: simplify the summary api a bit

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested review from maiamcc and milas March 23, 2021 20:03
@nicks nicks merged commit c215ec5 into master Mar 24, 2021
@nicks nicks deleted the nicks/summary branch March 24, 2021 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants