Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web: move sidebar pin buttons to left of resources #4391

Merged
merged 3 commits into from Apr 5, 2021
Merged

web: move sidebar pin buttons to left of resources #4391

merged 3 commits into from Apr 5, 2021

Conversation

landism
Copy link
Member

@landism landism commented Mar 31, 2021

Problem

Users find it annoying when:

  • They move the mouse over to the sidebar to click on a resource
  • At the last instant, due to hover, the "pin this resource" button pops up, stealing their click and doing something different than their intent

Solution

Move the pin button outside of the sidebar resource boxes

(this is part of the in-progress pin/star redesign)

old:

new:

@landism landism requested review from hyu and nicks March 31, 2021 17:54
@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #11762: move pin icon to left of sidebar resource box.

@landism landism merged commit 92bf9b6 into master Apr 5, 2021
@landism landism deleted the mlandis/ch11762/move-pin-icon-to-left-of-sidebar-resource branch April 5, 2021 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicks nicks nicks approved these changes

@hyu hyu Awaiting requested review from hyu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@landism @nicks