engine: add status for PodLogStream #4395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Clubhouse Story #11770: write PodLogStream status. |
|
I also feel like I'm missing an easy abstraction for queuing and updating the API server with status updates...i haven't spent much time looking at how Kubernetes code does this... |
nicks
force-pushed
the
nicks/ch11770
branch
3 times, most recently
from
bfb9fed
to
5085f99
Compare
milas
approved these changes
Apr 5, 2021
There was a problem hiding this comment.
Looks good to me once it gets tilt-dev/tilt-apiserver#29 rolled in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @milas, @maiamcc,
Please review the following commits I made in branch nicks/ch11770:
a47119e (2021-04-01 17:39:37 -0400)
engine: add status for PodLogStream
8fef11a (2021-03-31 19:59:31 -0400)
engine: make podlogmanager a reconciler
Code review reminders, by giving a LGTM you attest that: