build: attach name of pipeline step to summary #4396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
landism
approved these changes
Apr 2, 2021
| Name: stepName, | ||
| Index: ps.curPipelineIndex() + 1, | ||
| } | ||
| line := logger.Blue(l).Sprintf("STEP %d/%d", ps.curPipelineIndex(), ps.totalPipelineStepCount) |
There was a problem hiding this comment.
Would this be simpler?
- remove the
PipelineStep.Indexfield - remove
curPiplineIndexand replacing withlen(ps.pipelineSteps)(or with+ 1or whatever) - remove
curPiplineStep, and the new step immediately, and usepipelineSteps[len(pipelineSteps)-1]in EndPipelineStep (which I think is the only place this gets used?)
internal/build/pipeline_state.go
Outdated
| Index: ps.curPipelineIndex() + 1, | ||
| } | ||
| line := logger.Blue(l).Sprintf("STEP %d/%d", ps.curPipelineIndex(), ps.totalPipelineStepCount) | ||
| l.Infof("%s — %s", line, stepName) | ||
| ps.curBuildStep = 1 | ||
| ps.curPipelineStepStart = ps.c.Now() |
There was a problem hiding this comment.
wanna pull this field into the PipelineStep struct?
internal/build/pipeline_state.go
Outdated
| @@ -35,7 +46,7 @@ const buildStepOutputPrefix = " " | |||
|
|
|||
| func NewPipelineState(ctx context.Context, totalStepCount int, c Clock) *PipelineState { | |||
| return &PipelineState{ | |||
| curPipelineStep: 1, | |||
| curPipelineStep: PipelineStep{Index: 0}, | |||
There was a problem hiding this comment.
IIUC it's idiomatic go to omit initializations to 0-values like this (both the Index and the PipelineStep here are such initializations)
(this is irrelevant if you agree with my below comment to delete curPipelineStep)
There was a problem hiding this comment.
ha whoops yes. it used to be initialized to 1 and then i changed it but heh.
web/src/subdir/index.test.js
Outdated
| @@ -0,0 +1,3 @@ | |||
| test("everything is okay", () => { | |||
added 3 commits
April 2, 2021 17:13
This reverts commit 1672831.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@theothertomelliott asked what the steps a la--
in the web UI corresponded to.
these are steps in our update pipeline (e.g. "building dockerfile [gcr.io/xyz]", "Deploying to k8s"), which ARE given names at some point, but you need to scroll back up through the logs to associate the step and its name with the duration given below
this PR attaches the step name to its duration when we print the pipeline summary
I don't feel great about how the way we store
pipelineStepandbuildStephave diverged, but I figure this is fine for nowcc @hyu for "does this look ugly" consult