Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: add starred resource bar to storybook #4398

Merged

Conversation

landism
Copy link
Member

@landism landism commented Apr 2, 2021

image

This is just the component + story - it's not yet actually used by the UI.

The overflow behavior is just to keep expanding vertically, which isn't ideal, but 1) isn't awful and 2) only affects users who star resources, and star many of them.

@landism landism requested review from hyu and nicks April 2, 2021 17:52
@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #11764: implement storybook story for starred resource bar.

web/package.json Outdated Show resolved Hide resolved
@landism landism requested a review from nicks April 6, 2021 18:29
web/src/StarredResourceBar.stories.tsx Show resolved Hide resolved
web/src/StarredResourceBar.tsx Outdated Show resolved Hide resolved
web/src/StarredResourceBar.tsx Show resolved Hide resolved
@landism landism merged commit a6b0e1b into master Apr 7, 2021
@landism landism deleted the mlandis/ch11764/implement-storybook-story-for-starred-resource branch April 7, 2021 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants