Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podlogstream: move the reconciler into its own package #4410

Merged
merged 1 commit into from
Apr 7, 2021
Merged

Conversation

nicks
Copy link
Member

@nicks nicks commented Apr 7, 2021

Hello @nicks,

Please review the following commits I made in branch nicks/repkg:

6ba3ef0 (2021-04-07 15:05:47 -0400)
podlogstream: move the reconciler into its own package

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks merged commit 89be6cb into master Apr 7, 2021
@nicks nicks deleted the nicks/repkg branch April 7, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant