Revert "engine: consider Unschedulable pods as being in error state" #4413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, this is too aggressive and can cause
tilt cito fail even when everything will come up successfully but isn't doing so fast enough.The behavior we're reverting to is still technically correct - the pod is pending. We'd like to frame that as an error if it's going to be waiting indefinitely, but we can't accurately make that determination with the state available.
Perhaps this would be better addressed as an optional flag/config for
tilt ciof a "max resource startup duration" that could generically cause it to fail if a resource is still in pending after some user-determined amount of time to avoid atilt ciprocess that runs indefinitely but avoid pitfalls like the one encountered here.Reverts #4386.
Closes #4412.