cli: add tilt alpha delete #4429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Clubhouse Story #11864: add tilt alpha delete. |
nicks
force-pushed
the
nicks/ch11864
branch
2 times, most recently
from
9b67d70
to
5ed7b0a
Compare
milas
approved these changes
Apr 14, 2021
| err = deleteCmd.run(f.ctx, []string{"cmd", "my-sleep"}) | ||
| require.NoError(t, err) | ||
|
|
||
| assert.Contains(t, out.String(), `cmd.tilt.dev "my-sleep" deleted`) |
There was a problem hiding this comment.
Might be worth an assertion that f.client.Get() returns not found after this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @landism, @milas,
Please review the following commits I made in branch nicks/ch11864:
8ab9e31 (2021-04-14 12:20:22 -0400)
cli: add tilt alpha delete
Code review reminders, by giving a LGTM you attest that: