Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: add tilt alpha apply #4432

Merged
merged 1 commit into from Apr 14, 2021
Merged

cli: add tilt alpha apply #4432

merged 1 commit into from Apr 14, 2021

Conversation

nicks
Copy link
Member

@nicks nicks commented Apr 14, 2021

Hello @milas, @landism,

Please review the following commits I made in branch nicks/ch11865:

b26cb13 (2021-04-14 14:41:26 -0400)
cli: add tilt alpha apply

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested review from landism and milas April 14, 2021 18:43
@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #11865: add tilt alpha apply.


err = cmd.run(f.ctx, nil)
require.NoError(t, err)
assert.Contains(t, out.String(), `cmd.tilt.dev/my-sleep created`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to delete, might be worthwhile to just check that f.client.Get() can find my-sleep

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@nicks nicks force-pushed the nicks/ch11865 branch 3 times, most recently from 138e188 to 181c72b Compare April 14, 2021 20:14
@nicks nicks merged commit 85ae858 into master Apr 14, 2021
@nicks nicks deleted the nicks/ch11865 branch April 14, 2021 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants