Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: add tilt alpha create filewatch #4438

Merged
merged 1 commit into from Apr 16, 2021
Merged

cli: add tilt alpha create filewatch #4438

merged 1 commit into from Apr 16, 2021

Conversation

nicks
Copy link
Member

@nicks nicks commented Apr 14, 2021

Hello @milas,

Please review the following commits I made in branch nicks/filewatch:

c19e971 (2021-04-14 18:51:40 -0400)
cli: add tilt alpha create filewatch

ed7bbc6 (2021-04-14 17:32:58 -0400)
cli: add tilt alpha create

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested a review from milas April 14, 2021 22:51
@nicks
Copy link
Member Author

nicks commented Apr 14, 2021

I was originally hoping this could be autogenerated from the data models

but the more i thought about it

the more i think it might be better to have very fine-tunes CLIs with better defaults

tailored to only the data models you'd realistically want to create from the command-line

maybe will revisit auto-generating in the future

@nicks nicks changed the base branch from master to nicks/create April 14, 2021 22:53
Base automatically changed from nicks/create to master April 15, 2021 17:45
@nicks nicks force-pushed the nicks/filewatch branch 2 times, most recently from 074b7a0 to 2380e96 Compare April 15, 2021 18:49
@nicks
Copy link
Member Author

nicks commented Apr 16, 2021

updated to remove the 'paths' flag and just specify paths as extra args

@nicks nicks merged commit e941ca3 into master Apr 16, 2021
@nicks nicks deleted the nicks/filewatch branch April 16, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants