v1alpha1: one port forward object may contain multiple forwards #4489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maiamcc
force-pushed
the
maiamcc/api-portforward-per-pod
branch
from
d2c6c36
to
555f4f3
Compare
|
(note that this new data organization doesn't ENFORCE "one PortForward API object per pod", but it does allow the PortForwardSubscriber to create one per pod, which will make it easier to track/diff PFs against each other) |
milas
approved these changes
Apr 29, 2021
milas
reviewed
Apr 29, 2021
milas
reviewed
Apr 29, 2021
maiamcc
force-pushed
the
maiamcc/api-portforward-per-pod
branch
from
d24b602
to
76195ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per #4483 (comment), when we have one pf API object per pair of ports to forward between, it can get awkward to diff existing vs. desired in the subscriber.
this PR has the api object behaving more in line with the current port forward subscriber behavior -- one PF API object contains one or more forwards to run on the specified pod.