cmd: Cmd Terminated should rely on Process Wait() semantics instead of Go Cmd Wait() semantics #4493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Clubhouse Story #11952: cmd should delete its process group if the init process terminates. |
nicks
force-pushed
the
nicks/ch11952
branch
6 times, most recently
from
8d0ace6
to
15b093c
Compare
…f Go Cmd Wait() semantics The Go semantics are not what most people expect, and even Go team is considering changing them. Fixes #4456
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @landism,
Please review the following commits I made in branch nicks/ch11952:
bee2771 (2021-04-29 20:49:50 -0400)
cmd: Cmd Terminated should rely on Process Wait() semantics instead of Go Cmd Wait() semantics
The Go semantics are not what most people expect, and even Go team is considering changing them.
Code review reminders, by giving a LGTM you attest that: