k8s: defer extra pod labels conversion to labels.Selector #4495
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extra pod labels come in as one or more maps of label keys and values
(
[]labels.Set
). Once converted into a list oflabels.Selector
,it can be used for matching, but introspecting it is more difficult,
as it requires conversion, which produces a list of
labels.Requirement
. The biggest problem that introduces is thatlabels.Requirement
is more expressive, so backwards conversionmeans a bunch of error-handling for (what should be) impossible
cases.
This just passes the
labels.Set
s as they're parsed from theTiltfile
through and stores them that way on the target in state.Once they're actually used, they get converted to the actual
labels.Selector
s for matching.This will simplify the new intermediary step where they'll get
converted to API label selector objects, so that conversion can
happen without hiccups or excessive boilerplate.