Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apis: add kludge apis for representing tilt web UI #4502

Merged
merged 1 commit into from
May 4, 2021
Merged

Conversation

nicks
Copy link
Member

@nicks nicks commented May 3, 2021

Hello @milas, @maiamcc,

Please review the following commits I made in branch nicks/uisession:

61b6cd8 (2021-05-03 16:51:12 -0400)
apis: add kludge apis for representing tilt web UI

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested review from maiamcc and milas May 3, 2021 20:51
@nicks
Copy link
Member Author

nicks commented May 3, 2021

most of this code is autogenerated. just defining some empty data models, and jamming them into the protobuf that we use to drive the current web ui

@nicks
Copy link
Member Author

nicks commented May 4, 2021

i also thought about putting this in a separate group (e.g., ui.tilt.dev instead of tilt.dev) but maybe that's premature

@nicks nicks merged commit 8d9c103 into master May 4, 2021
@nicks nicks deleted the nicks/uisession branch May 4, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants