Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apimachinery: fork apimachinery to handle time jsonpb serialization #4518

Merged
merged 1 commit into from
May 6, 2021

Conversation

nicks
Copy link
Member

@nicks nicks commented May 5, 2021

Hello @milas,

Please review the following commits I made in branch nicks/serialization:

0a6c6dc (2021-05-05 16:31:48 -0400)
apimachinery: fork apimachinery to handle time jsonpb serialization

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested a review from milas May 5, 2021 20:32
@nicks nicks force-pushed the nicks/serialization branch 2 times, most recently from 08da91a to 343a425 Compare May 5, 2021 20:33
Copy link
Contributor

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the core issue here that we (or K8s?) are still using github.com/golang/protobuf ("v1") instead of google.golang.org/protobuf ("v2") since the latter replaces jsonpb with protojson?

@nicks
Copy link
Member Author

nicks commented May 6, 2021

ya, and we also use grpc-gateway to handle the protobuf json serialization. it's a kaleidoscope of incompatibilities!

@nicks nicks merged commit 93719de into master May 6, 2021
@nicks nicks deleted the nicks/serialization branch May 6, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants