apis: add UISession (a straight port of the old view.proto) #4525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the only hand-written stuff is in uisession_types.go , everything else is generated |
landism
approved these changes
May 6, 2021
| TiltCloudTeamName string `json:"tiltCloudTeamName" protobuf:"bytes,6,opt,name=tiltCloudTeamName"` | ||
|
|
||
| // TiltCloudSchemeHost reports the base URL of the Tilt Cloud instance | ||
| // associated with this Tilt binary. Usually https://cloud.tilt.dev |
There was a problem hiding this comment.
Suggested change
| // associated with this Tilt binary. Usually https://cloud.tilt.dev | |
| // associated with this Tilt process. Usually https://cloud.tilt.dev |
There was a problem hiding this comment.
(this is mostly changed via env var when running tilt)
| // associated with this Tilt binary. Usually https://cloud.tilt.dev | ||
| TiltCloudSchemeHost string `json:"tiltCloudSchemeHost" protobuf:"bytes,7,opt,name=tiltCloudSchemeHost"` | ||
|
|
||
| // TiltCloudTeamID reports the unique team name if the user is signed into |
There was a problem hiding this comment.
Suggested change
| // TiltCloudTeamID reports the unique team name if the user is signed into | |
| // TiltCloudTeamID reports the unique team id if the user is signed into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @milas, @landism,
Please review the following commits I made in branch nicks/uisession6:
4ec22ef (2021-05-06 15:15:34 -0400)
apis: add UISession (a straight port of the old view.proto)
Code review reminders, by giving a LGTM you attest that: