docker: support DOCKER_HOST=ssh://... remotes #4607
Conversation
Docker 18.09+ added support for SSH remote Docker connections. The code to handle this isn't actually in the Moby client portions that we use, but in the Docker CLI (which we already have a dependency on). This adapts some of the code from the Docker CLI that attempts to create a `ConnectionHelper` if the host value is set. Currently, the logic only creates a helper for `ssh://` hosts and returns nil otherwise, in which case the former logic is used (i.e. pass the host as-is to Moby). If a connection helper is created, it's used to create a custom HTTP client/transport that will use SSH under the hood. Fixes #4603.
milas
force-pushed
the
milas/docker-ssh-host
branch
2 times, most recently
from
52e4b19
to
a1e0352
Compare
|
Unfortunately, there's no great way to test this in CI that I can find. CircleCI actually configures the remote docker to be SSHable (docs) but there's enough other complexity/weirdness with port forwarding etc that it doesn't seem practical. |
If the next person to touch this is tempted to add a test, having some form of this comment in the code might save them some time. |
|
Good call - added a note in 61089f5. I really wanted to get a variation of one of the integration tests working, but there's just too many oddities to make it practical right now |
Docker 18.09+ added support for SSH remote Docker connections.
The code to handle this isn't actually in the Moby client portions
that we use, but in the Docker CLI (which we already have a
dependency on).
This adapts some of the code from the Docker CLI that attempts
to create a
ConnectionHelperif the host value is set. Currently,the logic only creates a helper for
ssh://hosts and returns nilotherwise, in which case the former logic is used (i.e. pass the
host as-is to Moby). If a connection helper is created, it's used
to create a custom HTTP client/transport that will use SSH under
the hood.
Fixes #4603.