Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: update ResourceNav context to avoid re-renders #4666

Merged
merged 1 commit into from
Jun 18, 2021
Merged

Conversation

nicks
Copy link
Member

@nicks nicks commented Jun 18, 2021

Hello @hyu, @lizzthabet,

Please review the following commits I made in branch nicks/resourcenav3:

ebf80a3 (2021-06-18 15:33:42 -0400)
web: update ResourceNav context to avoid re-renders

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested review from hyu and lizzthabet June 18, 2021 19:34
@nicks
Copy link
Member Author

nicks commented Jun 18, 2021

when i was playing around with logs re-rendering earlier, i had a couple sandboxes to test my understanding, and was able to carve off this piece of what i learned

@nicks nicks merged commit 117c5c3 into master Jun 18, 2021
@nicks nicks deleted the nicks/resourcenav3 branch June 18, 2021 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants