Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: add namespace flag #4668

Merged
merged 5 commits into from
Jun 25, 2021
Merged

cli: add namespace flag #4668

merged 5 commits into from
Jun 25, 2021

Conversation

lucieleblanc
Copy link
Contributor

@lucieleblanc lucieleblanc commented Jun 21, 2021 •
edited

A very basic default namespace flag, inspired by the change suggested in #1113.

tilt up --namespace=my-namespace

Documentation change in tilt.build #876.

@lucieleblanc lucieleblanc requested review from milas and removed request for milas June 21, 2021 15:09
@lucieleblanc lucieleblanc marked this pull request as ready for review June 22, 2021 22:48
@lucieleblanc lucieleblanc requested a review from milas June 22, 2021 22:48
@lucieleblanc lucieleblanc changed the title Add namespace flag cli: add namespace flag Jun 24, 2021
milas
milas approved these changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Left two very minor suggestions - feel free to take or leave 🙃

internal/k8s/client.go Outdated Show resolved Hide resolved
internal/cli/flags.go Outdated Show resolved Hide resolved
@lucieleblanc lucieleblanc merged commit 7ab1239 into master Jun 25, 2021
@lucieleblanc lucieleblanc deleted the lucieleblanc/namespace-flag branch June 25, 2021 18:10
@lucieleblanc lucieleblanc mentioned this pull request Jun 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milas milas milas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lucieleblanc @milas