engine: write ImageMaps to the apiserver #4677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicks
force-pushed
the
nicks/tiltfile
branch
2 times, most recently
from
e957294
to
24ad881
Compare
nicks
force-pushed
the
nicks/tiltfile2
branch
2 times, most recently
from
826d2b1
to
69d95a4
Compare
milas
approved these changes
Jun 22, 2021
landism
approved these changes
Jun 22, 2021
| // Fetch all the existing API objects that were generated from the Tiltfile. | ||
| func getExistingAPIObjects(ctx context.Context, client ctrlclient.Client) (objectSet, error) { | ||
| result := objectSet{} | ||
|
|
||
| // TODO(nick): There's got to be a more generic way to do this. |
There was a problem hiding this comment.
oy, I take it the dynamic client would be ugly to use here?
There was a problem hiding this comment.
ya, the List object interface isn't super helpful here
https://pkg.go.dev/github.com/tilt-dev/tilt-apiserver/pkg/server/builder/resource#ObjectList
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @milas, @landism,
Please review the following commits I made in branch nicks/tiltfile2:
f42326d (2021-06-22 13:00:23 -0400)
engine: write ImageMaps to the apiserver
861df88 (2021-06-22 12:40:53 -0400)
engine: make the tiltfile loader write to the API server
Code review reminders, by giving a LGTM you attest that: