kubernetesapply: reconcile objects #4693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicks
force-pushed
the
nicks/ka
branch
2 times, most recently
from
1357043
to
714e79c
Compare
milas
approved these changes
Jun 25, 2021
|
|
||
| result := Result{ | ||
| Spec: spec, | ||
| Status: status, |
There was a problem hiding this comment.
I think this usage is actually provably safe right now (status has no reference types + based on code paths we never actually use both the return + the version stored in results), but it might be good to *status.DeepCopy() here anyway to avoid a future surprise (or incur the wrath of the race detector)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @milas,
Please review the following commits I made in branch nicks/ka:
f14dd9d (2021-06-25 13:28:50 -0400)
kubernetesapply: reconcile objects
Code review reminders, by giving a LGTM you attest that: