configs: create filewatches during tiltfile creation #4696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is mainly taking the code in manifest subscriber and moving it over to tiltfile creation... |
|
this should be much simpler and easier to reason about in general because:
|
milas
approved these changes
Jun 28, 2021
| @@ -492,7 +491,6 @@ func NewState() *EngineState { | |||
| } | |||
|
|
|||
| ret.Cmds = make(map[string]*Cmd) | |||
| ret.FileWatches = make(map[types.NamespacedName]*v1alpha1.FileWatch) | |||
There was a problem hiding this comment.
It's so nice to see these go away
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @milas,
Please review the following commits I made in branch nicks/fw:
9af8f1d (2021-06-28 11:55:02 -0400)
configs: create filewatches during tiltfile creation
Code review reminders, by giving a LGTM you attest that: