Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine: genericify API fetching a bit #4710

Merged
merged 1 commit into from Jun 30, 2021
Merged

engine: genericify API fetching a bit #4710

merged 1 commit into from Jun 30, 2021

Conversation

nicks
Copy link
Member

@nicks nicks commented Jun 29, 2021

Hello @milas, @landism,

Please review the following commits I made in branch nicks/meta:

fa80fb4 (2021-06-29 18:04:56 -0400)
engine: genericify API fetching a bit

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested review from landism and milas June 29, 2021 22:14
@nicks nicks merged commit 1570658 into master Jun 30, 2021
@nicks nicks deleted the nicks/meta branch June 30, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants