web: show options forms on uibuttons w/ inputs #4879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Clubhouse Story #12538: UI: allow user to see/edit text inputs. |
nicks
approved these changes
Aug 24, 2021
|
|
||
| type ApiButtonProps = { className?: string; button: UIButton } | ||
|
|
||
| type ApiIconProps = { iconName?: string; iconSVG?: string } | ||
|
|
||
| export const ApiButtonInputsToggleButton = styled(InstrumentedButton)` | ||
| &&&& { |
There was a problem hiding this comment.
https://styled-components.com/docs/faqs#how-can-i-override-styles-with-higher-specificity
I was on the fence about whether to comment this or relying on people learning styled components.
landism
deleted the
mlandis/ch12538/ui-allow-user-to-see-edit-text-inputs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a UIButton's spec defines one or more inputs:
The design/flow is currently a bit awkward but probably good enough to have people play around with it. The main goal was to come up one design that'd work for all button locations for now.
Here's how it looks in the nav bar:
In table view:
In overview action bar (on resource pane):
In action:
