UIButton: add bool inputs

[landism]

Allows buttons to have bool inputs, e.g.

Decided to add this since --dry-run makes for a good example

The TrueString / FalseString fields in UIBoolInputSpec is for convenience to allow direct substitution in stuff like this:

cmd_button('dothing',
           argv=['sh', '-c', './dothing.sh $DRY_RUN'],
           location=location.NAV,
           text='Do a thing',
           inputs=[
             bool_input('DRY_RUN', true_string='--dry-run', false_string=''),
           ]
)

rather than having to do stuff like $(if [[ $DRY_RUN == true ]]; then echo --dry-run; fi) in the command.

[lizzthabet]

i tested this locally with the sample button you shared and noticed that the button moves a bit when it's clicked and think you might need to disableRipple (lol) at the dropdown button:

from a design perspective, i'm not sure it makes sense that the boolean dropdown takes up so much real estate, given that there's only one option ever going to be displayed there. i wonder if making the width smaller would improve it:

(i'd also be curious about what a toggle control would look like here, instead of a checkbox, because this input is functioning more like an on/off switch, but i don't want to open up a can of design worms! i think it's fine for now.)

[landism]

i tested this locally with the sample button you shared and noticed that the button moves a bit when it's clicked and think you might need to disableRipple (lol)

github doesn't have :lolsob: :(

[landism]

the button moves a bit when it's clicked and think you might need to disableRipple (lol) at the dropdown button

1. good catch!
2. I've figured out how to disableRipple (apparently ButtonGroup applies its own defaults over top of the Buttons it contains)
3. the button still moves a bit :(
4. this happens in master as well, so I filed ch12630 and will tackle that separately

from a design perspective, i'm not sure it makes sense that the boolean dropdown takes up so much real estate, given that there's only one option ever going to be displayed there

It looks like the width in that screenshot is determined by the popup's title, so we'd presumably shrink the font or wrap it?
FWIW, I suspect in the medium term we'll want to replace that dialog with a different component entirely - it doesn't feel great as-is, and was mostly just a thing that already existed and worked well enough.

i'd also be curious about what a toggle control would look like here, instead of a checkbox, because this input is functioning more like an on/off switch

Yeah, that sounds nice. And also maybe give me an excuse to animate our existing toggles :)