tiltfile: Pass the Tiltfile model into TiltfileLoader #4949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicks
force-pushed
the
nicks/fetcher2
branch
4 times, most recently
from
d1dcea2
to
ded00f6
Compare
nicks
force-pushed
the
nicks/fetcher2
branch
from
ded00f6
to
94978cd
Compare
milas
approved these changes
Sep 9, 2021
| @@ -5879,6 +5882,7 @@ type fixture struct { | |||
| k8sContext k8s.KubeContext | |||
| k8sEnv k8s.Env | |||
| webHost model.WebHost | |||
| ctrlclient ctrlclient.Client | |||
There was a problem hiding this comment.
Is this intentional (maybe going to be imminently used)? AFAICT the TiltfileLoader doesn't actually need the client (yet?)
There was a problem hiding this comment.
ya, i have a branch that unifies the reconciler with the existing extension system so you can do:
extension_repo(name='default', url='file://path/to/my/repo')
extension(name='kubefwd', repo_name='default', path='kubefwd')
load('ext://kubefwd', ...)
and the tiltfile loader will ask the reconciler to load the extension instead. i think that will be a lot more flexible in general.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @landism, @milas,
Please review the following commits I made in branch nicks/fetcher2:
5f94b0f (2021-09-09 12:27:43 -0400)
tiltfile: Pass the Tiltfile model into TiltfileLoader
Code review reminders, by giving a LGTM you attest that: