vendor: upgrade tilt-apiserver #4990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, I needed to rollback opentelemetry to v0.20.0, because that's what k8s uses. The difference between v1.0.0 and v0.20.0 isn't THAT big but it did requires some bridge code.
Ooof - hopefully the ecosystem upgrades to v1.0.0 so we don't get stuck between incompatible versions between deps at some point 😓 |
milas
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @milas,
Please review the following commits I made in branch nicks/vendor:
80912f5 (2021-09-28 11:14:18 -0400)
vendor: upgrade tilt-apiserver
Unfortunately, I needed to rollback opentelemetry to v0.20.0, because
that's what k8s uses. The difference between v1.0.0 and v0.20.0 isn't THAT big
but it did requires some bridge code.
Code review reminders, by giving a LGTM you attest that: