engine: temporarily replicate FileWatch, KubernetesApply, and KubernetesDiscovery back to the EngineState #4997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicks
force-pushed
the
nicks/liveupdate7
branch
2 times, most recently
from
75b0d3a
to
8103006
Compare
|
looking forward to when we have generics in Go!!! |
nicks
force-pushed
the
nicks/liveupdate7
branch
from
8103006
to
4eb97b5
Compare
…tesDiscovery back to the EngineState This will help enable the tried-and-true pattern of "let's make everything use API models before moving them to the reconciler"
nicks
force-pushed
the
nicks/liveupdate7
branch
from
4eb97b5
to
6194e94
Compare
landism
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @landism, @milas,
Please review the following commits I made in branch nicks/liveupdate7:
b14c6bd (2021-09-29 13:19:02 -0400)
engine: temporarily replicate FileWatch, KubernetesApply, and KubernetesDiscovery back to the EngineState
This will help enable the tried-and-true pattern of
"let's make everything use API models before moving them to the reconciler"
Code review reminders, by giving a LGTM you attest that: