Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildcontrol: minor tweaks to docker image reporting #5214

Merged
merged 1 commit into from
Nov 22, 2021
Merged

buildcontrol: minor tweaks to docker image reporting #5214

merged 1 commit into from
Nov 22, 2021

Conversation

nicks
Copy link
Member

@nicks nicks commented Nov 22, 2021

Hello @milas,

Please review the following commits I made in branch nicks/dockerimagetweak:

6aea913 (2021-11-22 16:52:59 -0500)
buildcontrol: minor tweaks to docker image reporting

  1. include the push phase
  2. strip docker.io/library prefix correctly

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks
buildcontrol: minor tweaks to docker image reporting
6aea913 
1) include the push phase
2) strip docker.io/library prefix correctly
@nicks nicks requested a review from milas November 22, 2021 21:53
@nicks nicks merged commit 98e29b4 into master Nov 22, 2021
@nicks nicks deleted the nicks/dockerimagetweak branch November 22, 2021 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milas milas milas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nicks @milas