Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goreleaser: add autocompletion to our homebrew formula #5217

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

nicks
Copy link
Member

@nicks nicks commented Nov 23, 2021

Hello @landism,

Please review the following commits I made in branch nicks/autocomplete:

e16852e (2021-11-23 13:44:15 -0500)
goreleaser: add autocompletion to our homebrew formula
Adapted from: Homebrew/homebrew-core#88977

Thanks to autocompletion support added in #5029

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

Adapted from: Homebrew/homebrew-core#88977

Thanks to autocompletion support added in #5029
@nicks nicks requested a review from landism November 23, 2021 18:44
@nicks nicks merged commit 646aa11 into master Nov 23, 2021
@nicks nicks deleted the nicks/autocomplete branch November 23, 2021 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants