kubernetesapply: improve cmd timeout handling #5221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the process is killed due to context timeout, it'll have a non-zero exit code (typically 137). In these instances, we'll let the user know the command took too long and point them at the Tiltfile API for `update_settings` so they can increase the timeout value if needed. Additionally, if stdout is empty on failure (which, given that the commands are only supposed to write YAML on success to it, it generally will be), it won't be output, so you don't get a blank `stdout:` in the logs.
landism
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the process is killed due to context timeout, it'll have a
non-zero exit code (typically 137).
In these instances, we'll let the user know the command took too
long and point them at the Tiltfile API for
update_settingssothey can increase the timeout value if needed.
Additionally, if stdout is empty on failure (which, given that
the commands are only supposed to write YAML on success to it, it
generally will be), it won't be output, so you don't get a blank
stdout:in the logs.