engine: make Tiltfile.Spec.Args single source of truth #5226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicks
reviewed
Nov 24, 2021
landism
changed the title
tilt args flow
|
Per Nick's comment, I've reverted the The main effect of this PR is now that |
nicks
reviewed
Nov 24, 2021
| @@ -18,6 +18,10 @@ func HandleTiltfileUpsertAction(state *store.EngineState, action TiltfileUpsertA | |||
| } | |||
| } | |||
|
|
|||
| if mn == model.MainTiltfileManifestName { | |||
| state.UserConfigState.Args = action.Tiltfile.Spec.Args | |||
nicks
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old Behavior
When we run
tilt args, it goes through a server.go api which edits the Tiltfile API object and also dispatches a SetTiltfileArgsAction to the engine to update EngineState.UserConfigState.Args.New Behavior
The engine sets EngineState.UserConfigState.Args based on the main Tiltfile's Spec.Args, with no separate action needed.
This means we can just edit the Tiltfile API object without having to have a
Store.