Add go_test_changes resource to Tiltfile #5231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicksieger
changed the title
nicks
approved these changes
Dec 2, 2021
| @@ -47,6 +47,22 @@ test: test-go test-js | |||
| shorttest: | |||
| go test -mod vendor -p $(GO_PARALLEL_JOBS) -short -tags skipcontainertests,skiplargetiltfiletests -timeout 100s ./... | |||
|
|
|||
| # Run recent changes as seen by Tilt, called from Tiltfile | |||
| uniq = $(if $1,$(firstword $1) $(call uniq,$(filter-out $(firstword $1),$1))) | |||
There was a problem hiding this comment.
would it make more sense to do this in a shell script?
i feel like i've gotten in trouble with stuff that slows down evaluation of the makefile -- and there doesn't seem to be a strong reason to do it in the makefile.
this is fine too though
There was a problem hiding this comment.
Compromise in 09ff0bb that only makes the target visible if run from inside Tilt/Tiltfile so that regular make commands are unaffected by the extra processing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a local resource to run tests in recently changed go packages. Uses a new makefile target to run
go testwith the most recent set of changes reported by Tilt.