dockercompose: upgrade compose-go to v1.0.8 #5233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `compose-go` library reached v1! It's also got fixes for (hopefully) all the big regressions from the Python version, particularly environment variable resolution. There are a couple changes to the client, predominantly to share more logic around loader options between the three code paths (`compose-go`, CLI fallback, fake/tests). Importantly, the `compose-go` logic for `Dockerfile` paths changed, such that they are no longer made to be absolute (unless an absolute path is used, at which point it won't be touched). They're assumed to be relative to the `context` in the general case. This actually only affects the assertions in the tests - Compose has flip-flopped behavior here multiple times, so Tilt already has logic to join the `dockerfile` path with the `context` path if the former is relative. (In theory, this is now the final behavior, as it was restoring v1 semantics to address compatibility with WSL, but I think I said the same thing last time they changed the path resolution semantics!)
nicks
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
compose-golibrary reached v1! It's also got fixes for(hopefully) all the big regressions from the Python version,
particularly environment variable resolution.
There are a couple changes to the client, predominantly to share
more logic around loader options between the three code paths
(
compose-go, CLI fallback, fake/tests).Importantly, the
compose-gologic forDockerfilepaths changed,such that they are no longer made to be absolute (unless an absolute
path is used, at which point it won't be touched). They're assumed
to be relative to the
contextin the general case. This actuallyonly affects the assertions in the tests - Compose has flip-flopped
behavior here multiple times, so Tilt already has logic to join the
dockerfilepath with thecontextpath if the former is relative.(In theory, this is now the final behavior, as it was restoring v1
semantics to address compatibility with WSL, but I think I said the
same thing last time they changed the path resolution semantics!)