Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

engine: add an up-to-date condition to all uiresources #5236

Merged
merged 1 commit into from
Nov 30, 2021
Merged

engine: add an up-to-date condition to all uiresources #5236

merged 1 commit into from
Nov 30, 2021

Conversation

nicks
Copy link
Member

@nicks nicks commented Nov 30, 2021

Hello @milas,

Please review the following commits I made in branch nicks/updated:

a0899bc (2021-11-30 15:35:37 -0500)
engine: add an up-to-date condition to all uiresources

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested a review from milas November 30, 2021 20:35
@nicks
Copy link
Member Author

nicks commented Nov 30, 2021

I'm ambivalent about the name for this. i could also imagine calling it "Updated". open to better ideas though

milas
milas approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name seems fine to me, I can't think of anything better - thought about Current, but it's rather cryptic. LatestUpdateDone? 🤷

@nicks nicks merged commit dd065a4 into master Nov 30, 2021
@nicks nicks deleted the nicks/updated branch November 30, 2021 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milas milas milas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nicks @milas