apis: add a Cluster object #5250
Conversation
| // cluster or an existing Docker Daemon (for Docker Compose). | ||
| type ClusterSpec struct { | ||
| // Connection spec for an existing cluster. | ||
| Connect *ClusterConnection `json:"connect,omitempty" protobuf:"bytes,1,opt,name=connect"` |
There was a problem hiding this comment.
Total nit, but s/Connect/Connection here for consistency with object type?
| // | ||
| // If not specified, will read the DOCKER_HOST env or use the default docker | ||
| // host. | ||
| Host string `json:"host,omitempty" protobuf:"bytes,1,opt,name=host"` |
There was a problem hiding this comment.
Not critical, but I'd add a couple examples of valid Docker connection strings here - "host" is ambiguous (Docker's fault, I realize), so it'd be helpful for anyone reading the docs to realize this is something like unix:///var/run/docker.sock or tcp://localhost:12345 and not just a hostname like docker.cluster.local
| // On Kubernetes, this will correspond to the kubernetes.io/arch annotation. | ||
| // | ||
| // On Docker, this will be the Architecture of the Docker daemon. |
There was a problem hiding this comment.
Do we need to normalize between these or do they use the same values? 🙏
There was a problem hiding this comment.
clarified that we're going to use GOARCH style!
There was a problem hiding this comment.
Since arch comes from nodes in the cluster, we're all good until someone makes a multi-node, multi-arch cluster. Maybe note that fact/assumption of uniform, "cluster"-wide arch?
There was a problem hiding this comment.
yep, didn't intend to suggest that this was the only arch, added a clarification
| @@ -0,0 +1,159 @@ | |||
| /* | |||
| Copyright 2020 The Tilt Dev Authors | |||
There was a problem hiding this comment.
| Copyright 2020 The Tilt Dev Authors | |
| Copyright 2021 The Tilt Dev Authors |
old copyright template. .emacs aside: (add-hook 'write-file-hooks 'copyright-update) 😉
| // On Kubernetes, this will correspond to the kubernetes.io/arch annotation. | ||
| // | ||
| // On Docker, this will be the Architecture of the Docker daemon. |
There was a problem hiding this comment.
Since arch comes from nodes in the cluster, we're all good until someone makes a multi-node, multi-arch cluster. Maybe note that fact/assumption of uniform, "cluster"-wide arch?
nicks
force-pushed
the
nicks/clusterdef
branch
from
4150728
to
8e0bbcd
Compare
Hello @milas, @nicksieger,
Please review the following commits I made in branch nicks/clusterdef:
4150728 (2021-12-03 15:33:35 -0500)
apis: add a Cluster object
Code review reminders, by giving a LGTM you attest that: