Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: finish wiring up the wait cmd :oops: #5253

Merged
merged 1 commit into from
Dec 7, 2021
Merged

cli: finish wiring up the wait cmd :oops: #5253

merged 1 commit into from
Dec 7, 2021

Conversation

nicks
Copy link
Member

@nicks nicks commented Dec 6, 2021

Hello @milas, @landism,

Please review the following commits I made in branch nicks/wait2:

c8e2d9c (2021-12-06 13:24:12 -0500)
cli: finish wiring up the wait cmd :oops:

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested review from landism and milas December 6, 2021 18:24
@nicks nicks merged commit 37b9138 into master Dec 7, 2021
@nicks nicks deleted the nicks/wait2 branch December 7, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants