cluster: add cluster reconciler and create connections #5260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milas
approved these changes
Dec 8, 2021
| // If no Host is specified, use the default Env from environment variables. | ||
| env := docker.Env(r.localDockerEnv) | ||
| if obj.Host != "" { | ||
| env = docker.Env{Host: obj.Host} |
There was a problem hiding this comment.
Won't you generally also need TLS client certs in this case?
There was a problem hiding this comment.
yep! i think there are some notes on this in the API structs - we're eventually going to need to support all the major docker client options. But for now i just wanted to have a placeholder here to demo what it would look like.
There was a problem hiding this comment.
(my current old-school remote cluster uses TCP+an authenticated tailscale tunnel without any client certs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @milas,
Please review the following commits I made in branch nicks/cluster2:
81c5297 (2021-12-07 19:19:33 -0500)
cluster: add cluster reconciler and create connections
Code review reminders, by giving a LGTM you attest that: